Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add Yahoo as provider for iOS, Android and Web #9443

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Aug 29, 2022

Description

See title

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added type: documentation Improvements or additions to documentation plugin: auth labels Sep 6, 2022
docs/auth/federated-auth.md Outdated Show resolved Hide resolved

Ensure the "Yahoo" sign-in provider is enabled on the [Firebase Console](https://console.firebase.google.com/project/_/authentication/providers)
with an API Key and API Secret set. Also make sure your Firebase OAuth redirect URI (e.g. my-app-12345.firebaseapp.com/__/auth/handler)
is set as your Authorization callback URL in your app's settings page on your Yahoo app's config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
is set as your Authorization callback URL in your app's settings page on your Yahoo app's config.
is set as your Authorization callback URL in your app's settings page on your app's Yahoo config.

docs/auth/federated-auth.md Outdated Show resolved Hide resolved
@russellwheatley
Copy link
Member

Hey @kevinthecheung, do you mind reviewing the small docs changes, please?

docs/auth/federated-auth.md Outdated Show resolved Hide resolved
docs/auth/federated-auth.md Outdated Show resolved Hide resolved
@Lyokone Lyokone merged commit 6c3108a into master Sep 7, 2022
@Lyokone Lyokone deleted the feat/yahoo branch September 7, 2022 07:36
@firebase firebase locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: auth type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants