feat: allow web to initialize from Dart lazily without crashing on missing initialization script #7302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehesp
reviewed
Nov 4, 2021
packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart
Outdated
Show resolved
Hide resolved
russellwheatley
requested changes
Nov 4, 2021
packages/firebase_analytics/firebase_analytics/example/lib/main.dart
Outdated
Show resolved
Hide resolved
packages/cloud_firestore/cloud_firestore_web/lib/cloud_firestore_web.dart
Outdated
Show resolved
Hide resolved
pr-Mais
force-pushed
the
@mais/web-lazy-initialize
branch
from
1cfcb9c
to
2f31486
Compare
pr-Mais
force-pushed
the
@mais/web-lazy-initialize
branch
from
2f31486
to
50ef5c4
Compare
|
Woohoo, so excited to see this PR! I think firebase_core also does not initialize lazily; to fix #3962 I think we need changes to firebase_core as well. |
lesnitsky
approved these changes
Nov 5, 2021
Ehesp
approved these changes
Nov 5, 2021
|
Ah I see, thanks for the explanation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow web plugins to register without crashing on missing initialization script, and allow to initialize web plugins only from Dart lazily.
Related Issues
Possibly fixes #3962
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?