Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs-info label should override the ignore-labels config #53

Open
samtstern opened this issue Mar 8, 2019 · 4 comments
Open

Needs-info label should override the ignore-labels config #53

samtstern opened this issue Mar 8, 2019 · 4 comments

Comments

@samtstern
Copy link
Contributor

Suggested by @mikelehen after this confusion:
firebase/firebase-js-sdk#1407
@samtstern
Copy link
Contributor Author

@Feiyang1 what do you think? Basically if someone marks an ignored issue (like a feature request) as needs-info then it can still be closed as stale.

@Feiyang1
Copy link
Member

Feiyang1 commented Mar 8, 2019 •
edited
Loading

I think updating the label text fixes the issue, so feature request won't be closed by bot ?

oops, Was it opened before you made change in google3? Sorry I'm too slow.

@samtstern
Copy link
Contributor Author

@Feiyang1 that's true. The question is: should the bot be able to close feature requests if a human has specifically tagged it with needs-info? Or no?

@Feiyang1
Copy link
Member

Feiyang1 commented Mar 9, 2019 •
edited
Loading

I think that makes sense. then let's just remove it from the ignore-labels. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Feiyang1 @samtstern