Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auxiliary files to release archive #44

Closed
outfrost opened this issue Dec 4, 2020 · 3 comments
Closed

Add auxiliary files to release archive #44

outfrost opened this issue Dec 4, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@outfrost
Copy link

outfrost commented Dec 4, 2020

This is a (hopefully small) feature request.

I am packaging a Godot project, and would like to include extra files, namely README.md and LICENSE, in the archive.

Using this action, it's possible to do that in workflow artifacts (by simply running cp before actions/upload-artifact). However, it is not easy, or at least not obvious how to do it in releases that this action creates.

In my example use case, I would like to achieve

LinuxX11.zip
|- LICENSE
|- README.md
|- project.pck
|- project.x86

It would be lovely if godot-export had either an input to specify files to be added to the archive, or a plain shell hook to execute a user-provided script in between exporting and archiving.

@firebelley firebelley added the enhancement New feature or request label Dec 4, 2020
@firebelley
Copy link
Owner

I like both of those ideas. The pre-archive hook would open up a ton of possibilities for further extensibility as well.

The tricky part is Mac builds are automatically exported as archived, so there needs to be additional logic to open the archive up, copy the files, then archive it again.

In the meantime, I believe you can accomplish what you want within Godot by utilizing the EditorExportPlugin API. See this comment godotengine/godot#22950 (comment)

This will allow you to copy files alongside your export during the Godot export process, which will work just fine with this action.

@outfrost
Copy link
Author

outfrost commented Dec 4, 2020

Thanks a lot for pointing me to that script! I had searched through issues in godot but couldn't find that.

@firebelley
Copy link
Owner

This action has changed quite a bit with 4.0.0. I now believe it's possible to do a lot more with this action. Feel free to reopen if this is an issue that's still worth discussing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants