This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Handle out-of-order declarations in scopes. #5690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
reviewed
Mar 16, 2018
| end: fromBabelLocation(node.loc.end, state.sourceId), | ||
| meta: buildMetaBindings(state.sourceId, node, ancestors) | ||
| }); | ||
| let freeVariables = state.freeVariables.get(node.name); |
There was a problem hiding this comment.
what's this doing? can you add some comments here for what a free variable is
jasonLaster
reviewed
Mar 16, 2018
| if (binding) { | ||
| binding.refs = freeVariables.concat(binding.refs); | ||
| } | ||
| } |
There was a problem hiding this comment.
does it also help to have a unit test for the visitor so that we have more direct tests of this case, which would be easier to fix than the mochitest
|
i think all of these PRs are blocked by unrelated travis fails... i'll fix them in #5689 which was in hindsight too narrow |
darkwing
force-pushed
the
out-of-order-decl
branch
from
1d2f26a
to
662acf1
Compare
loganfsmyth
force-pushed
the
out-of-order-decl
branch
from
662acf1
to
dca237e
Compare
loganfsmyth
force-pushed
the
out-of-order-decl
branch
from
dca237e
to
1330b21
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs Issue: #5561
Summary of Changes
enterbut doesn't try to find their related bindings untilexitTrying to associate the references with declarations on
enterleads to errors if the references is earlier in the file that the declaration.