This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
[Breakpoints] Fix timing issue with showing breakpoints #7365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
force-pushed
the
fix-breakpoints
branch
from
c69ff6d
to
3176f52
Compare
|
yeah - i buy that |
darkwing
force-pushed
the
fix-breakpoints
branch
from
3176f52
to
8c949d8
Compare
darkwing
reviewed
Jan 7, 2019
| @@ -576,7 +576,7 @@ class Editor extends PureComponent<Props, State> { | |||
| const { horizontal, selectedSource, conditionalPanelLocation } = this.props; | |||
| const { editor } = this.state; | |||
|
|
|||
| if (!editor || !selectedSource) { | |||
| if (!selectedSource || !editor || !getDocument(selectedSource.id)) { | |||
There was a problem hiding this comment.
Two tests fail, each test containing the following line:
await waitForElementWithSelector(dbg, ".CodeMirror-code > .highlight-line");The addition of || !getDocument(selectedSource.id) is causing the failure; if it is removed, the tests pass.
jasonLaster
added a commit
that referenced
this pull request
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7289
Summary of Changes
breakpoints and other components wont try rendering unless there's a doc