This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fix #7951 - Keep scroll position of documents when changing tabs #8102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7951
This isn't perfect but it's a big improvement over the current behavior.
Since
selectLocationdefaults to1, every time a document is selected, the first line is selected and highlighted. One way to isolate knowing when we truly want line 1 is assigning line 1 to the location if the source isn't open yet and no line assigned.Where this patch isn't perfect is when you open tabs and refresh the page; since the tabs exist, the scroll isn't changed. It's almost as if documents aren't defaulting back to line 1...