Extract the meta info formatting to a separate file #2617
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2617 +/- ##
=======================================
Coverage ? 86.41%
=======================================
Files ? 218
Lines ? 17377
Branches ? 4512
=======================================
Hits ? 15016
Misses ? 2162
Partials ? 199 Continue to review full report at Codecov.
|
| function _formatMetainfoString(meta: ProfileMeta) { | ||
| const productAndVersion = formatProductAndVersion(meta); | ||
| const os = formatPlatform(meta); | ||
| return productAndVersion + (os ? ` – ${os}` : ''); | ||
| } |
There was a problem hiding this comment.
I kept it here because in the future it will disappear: indeed we'll display the 2 parts in 2 different elements, because we'll also want to add small icons to represent the platforms and products. Very probably this will all go to a different component.
julienw
force-pushed
the
extract-metainfo-formatting
branch
from
06b6cfe
to
b0251a7
Compare
There was a problem hiding this comment.
Thanks for the PR and lots of deploy previews! Looks good to me with some nits and suggestions but implementation wise I like this version! A lot clearer with less distractions!
Also it would be good to test it with a Chrome profile. Not sure if we are putting version and platform information to chrome profiles.
|
Thanks for the review! |
I'll be using these new functions when displaying the information about saved profiles.
Deploy previews:
Look at both the profile info summary, and also inside the summary itself.