Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate components to only used named exports, not default exports. #2819 (stack-chart) #2835

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

r1jsheth
Copy link
Contributor

@r1jsheth r1jsheth commented Oct 3, 2020

Migrate components to only used named exports, not default exports. #2819

Named export for src/components/stack-chart

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #2835 into main will increase coverage by 0.69%.
The diff coverage is 87.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2835      +/-   ##
==========================================
+ Coverage   86.55%   87.25%   +0.69%     
==========================================
  Files         219      234      +15     
  Lines       17446    18686    +1240     
  Branches     4534     4762     +228     
==========================================
+ Hits        15101    16305    +1204     
- Misses       2148     2198      +50     
+ Partials      197      183      -14     
Impacted Files Coverage Δ
src/components/app/CompareHome.js 100.00% <ø> (ø)
src/components/app/Details.js 82.35% <ø> (+23.52%) ⬆️
src/components/app/DetailsContainer.js 100.00% <ø> (ø)
src/components/app/MenuButtons/Publish.js 75.72% <ø> (ø)
src/components/app/ProfileViewer.js 84.61% <ø> (-2.06%) ⬇️
src/components/app/Root.js 100.00% <ø> (+100.00%) ⬆️
src/components/js-tracer/Canvas.js 76.76% <ø> (ø)
src/components/js-tracer/index.js 100.00% <ø> (ø)
src/components/shared/SampleTooltipContents.js 0.00% <ø> (ø)
src/components/shared/chart/Canvas.js 89.55% <ø> (ø)
... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436882a...d026bc9. Read the comment docs.

Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants