Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the marker deriving step, and remove processing for Bailout and Invalidation #2851

Merged
merged 4 commits into from
Oct 8, 2020

Conversation

gregtatum
Copy link
Member

@gregtatum gregtatum commented Oct 7, 2020

before - after - Firefox 72 - Working derived bailout markers, no payload marker
before - after - Firefox 82 - Broken derived bailout markers, no payload marker
before - after - Firefox 83 - Text payload bailout markers

Our bailout markers are very divergent in the forms. Combined with the marker schema changes, things aren't working as expected. This PR strips out all of the special handling for markers, and completely relies on Gecko for the display.

@gregtatum gregtatum requested a review from julienw October 7, 2020 14:49
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #2851 into main will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
+ Coverage   87.39%   87.50%   +0.11%     
==========================================
  Files         235      234       -1     
  Lines       18788    18700      -88     
  Branches     4770     4757      -13     
==========================================
- Hits        16420    16364      -56     
+ Misses       2189     2161      -28     
+ Partials      179      175       -4     
Impacted Files Coverage Δ
src/components/tooltip/Marker.js 97.11% <ø> (-0.09%) ⬇️
src/profile-logic/marker-data.js 96.47% <ø> (+6.33%) ⬆️
src/profile-logic/marker-schema.js 94.96% <ø> (ø)
src/selectors/per-thread/markers.js 94.39% <ø> (-0.06%) ⬇️
src/components/app/SymbolicationStatusOverlay.js 23.80% <0.00%> (-3.47%) ⬇️
src/components/app/ProfileViewer.js 84.61% <0.00%> (-1.10%) ⬇️
src/components/app/Details.js 82.35% <0.00%> (-0.99%) ⬇️
src/components/app/ListOfPublishedProfiles.js 95.14% <0.00%> (-0.56%) ⬇️
src/components/app/ZipFileViewer.js 67.07% <0.00%> (-0.40%) ⬇️
src/components/app/Home.js 65.68% <0.00%> (-0.34%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a469520...e30c7b8. Read the comment docs.

Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up, this seems to work just fine!

Let's see if our users want the structured version back...
Crazy idea: maybe using the new "naming group" functionality in regexps we could be able to support such a processing purely in the schema
image

{
  structuringRegexp: "Invalidate (?<url>[\w/_-]+):(?<lineNumber>\d+):(?<columnNumber>\d+)",
  structuringRegexpApplyTo: "name",
  tooltipLabel: "{regexp.groups.url} at line {regexp.groups.lineNumber} and column {regexp.groups.columnNumber}",
}

(crazy idea I said)

src/profile-logic/marker-data.js Show resolved Hide resolved
src/selectors/per-thread/markers.js Show resolved Hide resolved
src/test/components/TooltipMarker.test.js Outdated Show resolved Hide resolved
src/profile-logic/marker-data.js Show resolved Hide resolved
Copy link
Member Author

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy idea: maybe using the new "naming group" functionality in regexps we could be able to support such a processing purely in the schema

Part of my thought process on the marker schema is that it can be an attack vector. I'm hesitant to open things up where we're executing regexes from random user data. I'd prefer to make the data structured if we can.

src/profile-logic/marker-data.js Show resolved Hide resolved
src/selectors/per-thread/markers.js Show resolved Hide resolved
src/test/components/TooltipMarker.test.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants