Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate relative paths to absolute: src/components/shared part 3 #2878 #2911

Merged
merged 7 commits into from Oct 12, 2020
Merged

Migrate relative paths to absolute: src/components/shared part 3 #2878 #2911

merged 7 commits into from Oct 12, 2020

Conversation

LizzyKate
Copy link
Contributor

@LizzyKate LizzyKate commented Oct 10, 2020 •
edited by canova

I migreted relative paths to absolute:src/components/shared parrt 3
Fixes #2878.

@nibble0101
Copy link
Contributor

I have noticed your branch is 26 commits behind firefox-devtools/main. Perhaps make it even.

@LizzyKate
Copy link
Contributor Author

I have updated the branch. Please review. Thanks

@LizzyKate
Copy link
Contributor Author

I have noticed your branch is 26 commits behind firefox-devtools/main. Perhaps make it even.

I have updated the branch. Please review. Thanks

@nibble0101
Copy link
Contributor

nibble0101 commented Oct 12, 2020 •
edited

I have noticed your branch is 26 commits behind firefox-devtools/main. Perhaps make it even.

I have updated the branch. Please review. Thanks

Hi @LizzyKate . I am also an applicant. That means I don't have write access to this repository. @julienw , @canova or @gregtatum can help you. Anyway LGTM.

@canova canova self-requested a review October 12, 2020 15:16
canova
canova approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@canova canova left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Looks good to me!

I added a small commit to re-order the import statements, we usually keep the imports from other packages at the top of imports list.

Also a side note: On your next PRs, it would be good to add the issue number to the first comment, so we can link the issue and PR together.

@canova canova merged commit ed9504a into firefox-devtools:main Oct 12, 2020
@LizzyKate
Copy link
Contributor Author

LizzyKate commented Oct 12, 2020 via email

@AyumiOsawa AyumiOsawa mentioned this pull request Oct 13, 2020
Merged
CipherGirl pushed a commit to CipherGirl/profiler that referenced this pull request Oct 13, 2020
@LizzyKate @canova @CipherGirl
Migrate relative paths to absolute: src/components/shared part 3 (PR f…
7c1462c 
…irefox-devtools#2911)

Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
Co-authored-by: Nazım Can Altınova <466239+canova@users.noreply.github.com>
@julienw julienw mentioned this pull request Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canova canova canova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate relative paths to absolute: src/components/shared part 3
3 participants
@LizzyKate @nibble0101 @canova