Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2876 Migrate relative paths to absolute: src/components/shared part 1 #2923

Merged
merged 5 commits into from Oct 13, 2020

Conversation

AyumiOsawa
Copy link
Contributor

This PR fixes issue #2876.

Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for the contribution.

@AyumiOsawa
Copy link
Contributor Author

Hello @gregtatum, thank you for taking the time to review this! This is my first contribution to the open-source project:)

I have a small question: I am slightly confused because someone else has already made the changes that I made in this PR, and those changes have already been merged into the project. Would my work here be merged to the repository and considered as a contribution, or would it be ignored?
(Merging my contribution in this PR may not make any differences to the entire project, but it makes a big difference to me as an applicant and I wanted to confirm this. Sorry for bugging you with a tiny thing!)

@gregtatum gregtatum merged commit 4b3b615 into firefox-devtools:main Oct 13, 2020
@gregtatum
Copy link
Member

@AyumiOsawa

Metrics in open source is weird, what's important is to apply continuous positive energy towards a project. A lot of these issues that are good first issues are more important to learn the process than the work actually getting done. For instance, congrats on your first open source contribution! Now you've successfully set up the project, and run the automated test suite to make sure the code didn't break. These are really the important changes compared to the lines of code changed.

Often I will work on a bigger feature and throw away the code, and that effort still counts towards contributions. In fact, helping others on the project can be as valuable as writing code.

Thanks for the contribution!

@canova
Copy link
Member

canova commented Oct 13, 2020

Oh, I missed that the changes on the other PR also included this PR's changes. Sorry about that, I should have caught it. I 100% agree what Greg said though. Thanks for your contribution!

@AyumiOsawa
Copy link
Contributor Author

@gregtatum @canova, thank you very much! Now I am getting the idea of contributing to open source projects. I will be proud of both of my merged and discarded contributions! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants