Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

v1.9.3.3 #59

Merged
merged 5 commits into from
Jun 7, 2017
Merged

v1.9.3.3 #59

merged 5 commits into from
Jun 7, 2017

Conversation

muhkuh2005
Copy link

Attention: Removes Symlink-Settings

@RiftLurker
Copy link

RiftLurker commented Jun 1, 2017

Any specific reason why this was built on top of v1.9.3.1 instead of v1.9.3.2?

EDIT: I just realised that it's also got the magento-1.9.3.2 as target branch, I guess someone with permission has to create the branch magento-1.9.3.3 first.

EDIT2: According to the changes it was indeed built on top of 1.9.3.2 was just surprised I didn't see any of the commits of 1.9.3.2 in there.

@ramsaybell
Copy link

ramsaybell commented Jun 1, 2017

@PostCrafter @muhkuh2005 I was in the process earlier today of doing this PR but @muhkuh2005 beat me to it :) I have completed it on my fork ( https://github.com/ohpolly/magento/tree/magento-1.9.3.3 ). I noticed though on my upgrade more files have been modified in comparison to this PR.

I used the magento-1.9.3.3-2017-05-31-02-39-51.tar archive from Magento. Also used a slightly adapted version of @AydinHassan script for generating the release - https://gist.github.com/ramsaybell/e970b431e9e2d50f07b5b0f19fb0f5c7

I also used firegento:magento-1.9.3.2 as my base for doing the upgrade. Not sure why this is but thought I should mention it anyway.

I have tested my fork upgrade using Toran Proxy and it seems to upgrade our Magento 1 codebase correctly.

@razbakov razbakov changed the base branch from magento-1.9.3.2 to magento-1.9.3.3 June 7, 2017 17:23
@razbakov razbakov merged commit e375159 into firegento:magento-1.9.3.3 Jun 7, 2017
@razbakov
Copy link

razbakov commented Jun 7, 2017

Thank you for pull request and review. I will create a new tag.

@leek leek mentioned this pull request Jun 8, 2017
@muhkuh2005 muhkuh2005 mentioned this pull request Sep 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants