Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

V1.9.3.6 #71

Closed
wants to merge 2 commits into from
Closed

Conversation

muhkuh2005
Copy link

No description provided.

Pascal Borkenhagen added 2 commits September 15, 2017 09:27
Had been removed by pull request firegento#67 from ohpolly/magento-1.9.3.4
@danslo
Copy link

danslo commented Sep 15, 2017

I've separately pushed it in branch magento-1.9.3.6 and drafted a new release instead of merging this into magento-1.9.3.4. Thanks for your contribution!

@danslo danslo closed this Sep 15, 2017
@muhkuh2005
Copy link
Author

That was my intention, but I cannot create new branches in this repo :)

@danslo
Copy link

danslo commented Sep 15, 2017

👍 Thanks again!

@muhkuh2005
Copy link
Author

Would it have been better to push it into the master then?
It looks like all the GIT-reference is now lost with your method.
As far as I remember the other mods had created a new branch with the pullrequest acceptance.
See #59

@danslo
Copy link

danslo commented Sep 15, 2017

I probably looked over the fact that you can do this in the github interface, so it's probably my mistake.

Just did a simple:

git fetch firegento pull/71/head:magento-1.9.3.6
git checkout magento-1.9.3.6
git push -u firegento magento-1.9.3.6

Maybe we can test this theory at 1.9.3.7 🤷‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants