Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark.Store Transaction Commit Fails Leaving Resource in 'queued' status #41

Closed
geronimovillarreal opened this issue Aug 12, 2015 · 1 comment
Labels

Comments

@geronimovillarreal
Copy link

When creating, updating or deleting a Resource document, the result of commiting the transaction is not evaluated for failure. When the sweep() function is called to move the Resource document from 'queued' to 'current' the collection save result is not evaluated. When this fails no exception is raised and the transaction is not rolled back leaving the Resource document in the state of 'queued'.

image

image

Proposed fix is to evaluate the result of Transaction.cs line 144 to ensure the Update was successful and the documents affected is equal to 1. If this evaluation fails, the sweep() mehod will throw an exception with the details of the failure so that the transaction fails and the Rollback() method is called.

@mbaltus mbaltus added this to the Spark 3.3 - DevDays2015 milestone Oct 19, 2015
@mbaltus mbaltus added the bug label Oct 19, 2015
@mharthoorn mharthoorn modified the milestones: Spark 4 - Montreal, Spark 3.7 - Orlando Dec 22, 2015
@kennethmyhra kennethmyhra removed this from the Spark - DevDays 2016 milestone Nov 7, 2019
@kennethmyhra
Copy link
Collaborator

Closing this, these methods are no longer used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants