Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when a process is assigned no meshes #9970

Closed
JakeOShannessy opened this issue Oct 10, 2021 · 4 comments
Closed

Segfault when a process is assigned no meshes #9970

JakeOShannessy opened this issue Oct 10, 2021 · 4 comments
Assignees

Comments

@JakeOShannessy
Copy link
Contributor

JakeOShannessy commented Oct 10, 2021

This came up when discussing #9968. When manually assigning meshes to MPI processes, if a process is skipped it produces a segfault.

The input below will produce such a segfault.

&HEAD CHID='process-skip-test' /
&MESH ID='MESH1' IJK=10,10,10, XB=0,1,0,1,0,1 MPI_PROCESS=0 /
&MESH ID='MESH2' IJK=10,10,10, XB=1,2,0,1,0,1 MPI_PROCESS=2 /
&MESH ID='MESH3' IJK=10,10,10, XB=2,3,0,1,0,1 MPI_PROCESS=2 /
&TAIL /

This should still be an error, but it's something that can be trivially caught with an error message produced. #9968 addresses this, but if that's not merged, it's a simple check to implement.

@mcgratta mcgratta self-assigned this Oct 11, 2021
@mcgratta
Copy link
Contributor

I'll fix this.

mcgratta pushed a commit to mcgratta/fds that referenced this issue Oct 11, 2021
mcgratta added a commit that referenced this issue Oct 11, 2021
FDS Source: Issue #9970. Add some ERROR statements for MPI_PROCESS
@mcgratta
Copy link
Contributor

I patched a few holes regarding the use of MPI_PROCESS.

@JakeOShannessy
Copy link
Contributor Author

Certainly seems to address it. Do you normally close issues on merge with master or with a new release?

@mcgratta
Copy link
Contributor

We close with user confirmation. We can always reopen if I broke something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants