Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for call location trace displacement #51

Closed
tylla opened this issue Jul 31, 2019 · 3 comments
Closed

Option for call location trace displacement #51

tylla opened this issue Jul 31, 2019 · 3 comments

Comments

@tylla
Copy link

tylla commented Jul 31, 2019

I am trying to introduce FirePHP to an existing project. (BTW I really love the whole concept)
The project uses a 'home made' but quite nice log system which offers a simple opportunity to use FirePHP-Core from one central location, but this poses a problem. All the log entries in the devtools FirePHP log show exact the same calling location, no wonder as this is the single place where FB::log() gets called.
This could be solved easily if FirePHP had an option to ignore the first 'n' entries from the trace but I couldn't find such an option (I tried to take a look into the code but no result).
Does such option exist (and I overlooked it) or if not could it be added?

@cadorn
Copy link
Member

cadorn commented Aug 29, 2019

I should get to this soon. The FirePHPCore lib is going to get some tests and then some improvements.

@cadorn
Copy link
Member

cadorn commented Sep 8, 2019

lineNumberOffset option now on master: https://github.com/firephp/firephp-core/blob/master/tests/Features/09-Wrappers.php#L51

@cadorn cadorn closed this as completed Sep 8, 2019
@tylla
Copy link
Author

tylla commented Sep 19, 2019

Nice job. Works as it should.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants