Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended tests to work with post-synth RTL #1439

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Extended tests to work with post-synth RTL #1439

merged 1 commit into from
Feb 27, 2023

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Feb 24, 2023

Includes improvements to post-synth simulations:

  • Added a QUICK strategy which tries to get Vivado to run fast, yet still helps us reproduce failures
  • Limited Vivado to 1 thread to mitigate flakyness from parallel synthesis
  • The harness now explicitly waits for GSR
  • Integrated post-synth metasims with the harness. Setting TEST_DISABLE_VIVADO=1 in the environment disables these tests even if Vivado is available.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@nandor nandor added the changelog:added Put PR title in 'Added' section of changelog label Feb 24, 2023
@nandor nandor force-pushed the post-synth-suites branch 2 times, most recently from 15e716d to 7ebb744 Compare February 24, 2023 20:17
@nandor nandor changed the title Extended midasexmaples and bridges tests work work with post-synth RTL Extended midasexmaples and bridge tests to work with post-synth RTL Feb 24, 2023
@nandor nandor changed the title Extended midasexmaples and bridge tests to work with post-synth RTL Extended tests to work with post-synth RTL Feb 24, 2023
Includes improvements to post-synth simulations:

- Added a `QUICK` strategy which tries to get Vivado to run fast, yet still helps us reproduce failures
- Limited Vivado to 1 thread to mitigate flakyness from parallel synthesis
- The harness now explicitly waits for GSR
- Integrated post-synth metasims with the harness. Setting `TEST_DISABLE_VIVADO=1` in the environment disables these tests even if Vivado is available.
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nandor nandor merged commit 0755382 into main Feb 27, 2023
@nandor nandor deleted the post-synth-suites branch February 27, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Put PR title in 'Added' section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants