Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependency tree #4403

Closed
3 tasks
jamilbk opened this issue Mar 30, 2024 · 0 comments · Fixed by #4475
Closed
3 tasks

Clean up dependency tree #4403

jamilbk opened this issue Mar 30, 2024 · 0 comments · Fixed by #4475
Labels
business_value/medium Required by between 10% and 50% of our customer base kind/refactor Code refactoring lang/rust Pull requests that update Rust code

Comments

@jamilbk
Copy link
Member

jamilbk commented Mar 30, 2024

It might be more tedious but maybe it's a good idea to have more target sections for each platform in our Cargo.tomls so that we aren't inadvertently linking in libraries that aren't used. It can be tough to remove them later, even relying on the linker to do so.

During our hunting session for #4377, @ReactorScram and I found lots of cross-pollination of dependencies across platforms.

@jamilbk jamilbk added kind/refactor Code refactoring lang/rust Pull requests that update Rust code business_value/medium Required by between 10% and 50% of our customer base labels Mar 30, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 3, 2024
These were all found by `cargo-udeps`.

Resolves: #4403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
business_value/medium Required by between 10% and 50% of our customer base kind/refactor Code refactoring lang/rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant