build(rust): Trigger warnings for unused crate dependencies #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
jamilbk
changed the title
Performance Test ResultsTCP
UDP
|
thomaseizinger
approved these changes
Mar 30, 2024
There was a problem hiding this comment.
I've had success with https://github.com/est31/cargo-udeps in the past.
| @@ -34,7 +34,9 @@ jobs: | |||
| cargo doc --all-features --no-deps --document-private-items ${{ matrix.packages }} | |||
| env: | |||
| RUSTDOCFLAGS: "-D warnings" | |||
| - run: | | |||
| - env: | |||
| RUSTFLAGS: "-Wunused-crate-dependencies" | |||
There was a problem hiding this comment.
You should be able to set this lint in Cargo.toml under the recently introduced lints table.
|
Superseded by #4475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all of the time spent hunting down all of our
fstatcalls for #4377, it became clear that our dependency tree is somewhat convoluted and includes a few unused crates and features.This is a first step to try to clean up some of those.
Refs #4403