Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): remove unused dependencies #4475

Merged
merged 8 commits into from Apr 3, 2024
Merged

chore(rust): remove unused dependencies #4475

merged 8 commits into from Apr 3, 2024

Conversation

thomaseizinger
Copy link
Member

@thomaseizinger thomaseizinger commented Apr 3, 2024 •
edited

These were all found by cargo-udeps.

Resolves: #4403.

@vercel Vercel
Copy link

vercel bot commented Apr 3, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 0:31am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 15 to destroy.

Terraform Cloud Plan

thomaseizinger
thomaseizinger commented Apr 3, 2024
View reviewed changes
rust/connlib/snownet/Cargo.toml
boringtun = { workspace = true }
firezone-relay = { workspace = true }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what that was doing in here 😅

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 223.5 MiB (-4%) 224.3 MiB (-5%) 446 (+1%)
direct-tcp-server2client 248.2 MiB (+4%) 248.9 MiB (+3%) 605 (-7%)
relayed-tcp-client2server 155.4 MiB (-3%) 156.3 MiB (-2%) 225 (+13%)
relayed-tcp-server2client 160.4 MiB (+7%) 160.8 MiB (+7%) 214 (+35%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.04ms (-1%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.01ms (-35%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.11ms (+30%) 0.03% (+Infinity%)
relayed-udp-server2client 50.0 MiB (-0%) 0.08ms (+23%) 0.00% (NaN%)

@thomaseizinger thomaseizinger force-pushed the chore/rust/remove-unused-dependencies branch 4 times, most recently from 80487f3 to 2d58339 Compare April 3, 2024 11:43
@thomaseizinger thomaseizinger force-pushed the chore/rust/remove-unused-dependencies branch from 2d58339 to 1684a40 Compare April 3, 2024 11:47
@thomaseizinger thomaseizinger force-pushed the chore/rust/remove-unused-dependencies branch from fdfc23b to d615391 Compare April 3, 2024 11:59
@thomaseizinger thomaseizinger force-pushed the chore/rust/remove-unused-dependencies branch from 4a738af to 1b3947f Compare April 3, 2024 12:16
@thomaseizinger
Copy link
Member Author

I had to fix some warnings in our code (1b3947f). Those showed up (and failed the build) because cargo udeps compiles the code using a nightly version and the nightly apparently has a better detection of unused imports that already come in via * imports.

I could move those to a separate PR but I am not sure it is worth it.

ReactorScram
ReactorScram approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@ReactorScram ReactorScram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I figure if you remove all that and it still compiles it's fine.

rust/gui-client/src-tauri/Cargo.toml
@@ -46,7 +42,7 @@ tauri = { version = "1.6", features = [ "dialog", "shell-open-api", "system-tray
tauri-runtime = "0.14.2"
tauri-utils = "1.5.3"
thiserror = { version = "1.0", default-features = false }
tokio = { version = "1.36.0", features = ["signal", "time"] }
tokio = { version = "1.36.0", features = ["signal", "time", "macros", "rt", "rt-multi-thread"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, it added those features that were accidentally pulled in from other packages in the workspace. That's been bugging me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add those manually :)

rust/gui-client/src-tauri/src/client/network_changes/linux.rs
Comment on lines -5 to -6
#[derive(thiserror::Error, Debug)]
pub(crate) enum Error {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this one didn't show up in Clippy.

@thomaseizinger thomaseizinger added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 97e6a92 Apr 3, 2024
153 checks passed
@thomaseizinger thomaseizinger deleted the chore/rust/remove-unused-dependencies branch April 3, 2024 14:26
@jamilbk
Copy link
Member

jamilbk commented Apr 3, 2024

Thanks for taking over this one!

@jamilbk jamilbk mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReactorScram ReactorScram ReactorScram approved these changes

@jamilbk jamilbk Awaiting requested review from jamilbk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up dependency tree
3 participants
@thomaseizinger @jamilbk @ReactorScram