ux(headless-client/linux): don't default to null DNS control #5063
Assignees
Comments
ReactorScram
added a commit
that referenced
this issue
May 21, 2024
Closes #5063 Almost all users are likely to have DNS resources, and it will be confusing if we silently don't allow those resources. Defaulting to `etc-resolv-conf` will break some systems, and defaulting to `systemd-resolved` means that it becomes part of the CLI contract. For now, make it explicit
ReactorScram
added a commit
that referenced
this issue
Jul 11, 2024
|
The PR's open for review. I fixed up a couple other DNS-related oddities there, like now we can explicitly disable DNS control on Windows |
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 6, 2024
…6163) Closes #5063, supersedes #5850 Other refactors and changes made as part of this: - Adds the ability to disable DNS control on Windows - Removes the spooky-action-at-a-distance `from_env` functions that used to be buried in `tunnel` - `FIREZONE_DNS_CONTROL` is now a regular `clap` argument again --------- Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I still worry about this UX as I think it's going to surprise nearly everyone that runs the headless client. Maybe the next thing to work on.
Originally posted by @jamilbk in #5007 (comment)
The text was updated successfully, but these errors were encountered: