Add more python tests #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 3 alerts and fixes 1 when merging eaa234c into 002a662 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 2 alerts and fixes 1 when merging 85330b0 into 002a662 - view on LGTM.com new alerts:
fixed alerts:
|
thebevrishot
force-pushed
the
functional-tests
branch
from
85330b0
to
455bde9
Compare
|
This pull request introduces 2 alerts and fixes 1 when merging 909f886 into c0c734b - view on LGTM.com new alerts:
fixed alerts:
|
a-bezrukov
approved these changes
Oct 2, 2020
psolstice
approved these changes
Oct 2, 2020
| @@ -129,7 +129,7 @@ std::pair<uint256,uint256> CHDMintWallet::RegenerateMintPoolEntry(CWalletDB& wal | |||
| /** | |||
| * Generate the mintpool for the current master seed. | |||
| * | |||
| * only runs if the current mintpool is exhausted and we need new mints (ie. the next mint to | |||
There was a problem hiding this comment.
Fixing formatting in unrelated files is evil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Add tests from the upper version of bitcoin for functionality that we lack tests.
Code changes brief
SyncWithChainto avoid hanging when try to encrypt wallet immediately after startup.