-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to data-valid-required and data-valid-pattern="" #6
Comments
What dies value do? Is it a replacement for something or additional attribute. |
data-valid="pattern" data-valid-value="\d" instead of data-pattern="\d" |
So data-valid="required"? |
yes, thoughts? |
How do you handle something that is valid and pattern? |
See above |
Not following. Data-valid=required data-valid=pattern data-valid-value=\d? |
well, as of right now, pattern implies required since \d will not pass if it's blank |
if we want to change that, we could to data-valid="required,pattern" or do data-valid-required or data-valid-pattern |
Will that work in all fields or just input? |
what other fields does pattern work on? |
I guess what im getting at is that required could be placed on a check box and then the regex won't work. And just because something has a regex doesn't mean it's required. |
I'm not following. regex obviously won't work on a check box. |
Did you intend for this library to be used on anything other than input boxes? |
yep, should work with all form elements. Do you see an issue with that? |
going to just namespace. data-valid-required, data-valid-pattern="\d" |
might be nicer to namespace the data attributes to avoid collision.
The text was updated successfully, but these errors were encountered: