Skip to content

Commit

Permalink
fish_realpath: filter out dangerous options
Browse files Browse the repository at this point in the history
Per feedback do not use aliases to declare wrapped functions.
  • Loading branch information
floam committed Sep 18, 2016
1 parent 3593b7e commit d84fde1
Showing 1 changed file with 41 additions and 6 deletions.
47 changes: 41 additions & 6 deletions share/functions/realpath.fish
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,45 @@
# If we see that there is an external command by that name we just return. That will cause fish to
# run the external command. On the other hand, if an external command isn't found we define a
# function that will provide fallback behavior.
if not command -v realpath > /dev/null
if command -v grealpath > /dev/null
alias realpath=grealpath
else
alias realpath=fish_realpath
end
if not command -s realpath >/dev/null

if command -s grealpath >/dev/null
function realpath -w grealpath -d "print the resolved path [grealpath]"
grealpath $argv
end
else
function realpath -w fish_realpath -d "get an absolute path without symlinks [fish_realpath]"
if test -z $argv
printf "usage: %s%s%s %sfile%s …\n" (set_color -o) $_ (set_color normal) (set_color -u) (set_color normal)
echo " resolves files as absolute paths without symlinks"
return 1
end

for arg in $argv
switch $arg
# These - no can do our realpath
case -s --strip --no-symlinks -z --zero --relative-base\* --relative-to\*
__fish_print_help fish_realpath
return 2

case -h --help --version
__fish_print_help fish_realpath
return 0

# Service commands called with these arguments by
# dropping the arguments to protext fish_realpath from them
# There are no sure things here
case -e --canonicalize-existing --physical -P -q --quiet -m --canonicalize-missing
continue

case "*"
fish_realpath $argv
end
end
end
end
end




0 comments on commit d84fde1

Please sign in to comment.