universal exported environment variable not exported anymore on subsequent assignations

[shouze]

Environment
fish --version	fish, version 3.1.0
uname -a	Linux sebastien-XPS-13-7390 4.15.0-1076-oem #86-Ubuntu SMP
echo $TERM	xterm-256color

How to reproduce?

If I run a parent fish process:

fish --debug="env-export" --debug-output=/tmp/parent.output -D 128 -l

When I execute the following commands, exported values are not recalculated on subsequent assignments:

echo "1. First assignment"
set -e my_var
set -S my_var
env | grep my_var && echo "env $my_var"
fish --debug="env-export" --debug-output=/tmp/child.output -D 128 -c 'set -Ux my_var foo'
# produces env-export: create_export_array() recalc: 1 in parent, 2 in child
env | string match my_var=\* && echo "env $my_var"
echo
echo "2. Second assignment, parent fish process is no more consistent about variable value"
fish --debug="env-export" --debug-output=/tmp/child.output -D 128 -c 'set -Ux my_var bar'
# produces env-export: create_export_array() recalc: 0 in parent, 2 in child
env | string match my_var=\* && echo "env $my_var"
echo
echo "3. Unless it reloads"
source ~/.config/fish/config.fish
# produces env-export: create_export_array() recalc: 2 in parent, 0 in child (no child exec)
env | string match my_var=\* && echo "env $my_var"

1. First assignment
$my_var: not set in local scope
$my_var: not set in global scope
$my_var: not set in universal scope

my_var=foo
env foo
$my_var: not set in local scope
$my_var: not set in global scope
$my_var: set in universal scope, exported, with 1 elements
$my_var[1]: length=3 value=|foo|

my_var=foo
env foo

2. Second assignment, parent fish process is no more consistent about variable value
my_var=bar
env bar
$my_var: not set in local scope
$my_var: not set in global scope
$my_var: set in universal scope, exported, with 1 elements
$my_var[1]: length=3 value=|bar|

my_var=foo
env bar

3. Unless it reloads
my_var=bar
env bar

[shouze]

This is maybe related to #5258 and #6218?

[krobelus]

Yeah, the exported variables need to be updated here

[shouze]

And maybe related to #6653? ping @ridiculousfish

Looks like there's a regression between 3.0.2 and 3.1.1 as I don't reproduce it on 3.0.2:

[krobelus]

Duplicate of #6612

[shouze]

@krobelus Ok, seen your fix, but I have bad news, I can still reproduce it. working on another issue to explain how. I'm now using HEAD's repo fish to ensure this gets fixed 😉

[shouze]

@krobelus ok no in fact all is good since your latest patch! 🎉
I had issues related to a Makefile in the project I've found the env var bug. I've also fixed on my side now.

[krobelus]

Sounds good, thanks for filing, please report if you find anything else that's fishy.