New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emerge completions #1840

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@JelteF
Contributor

JelteF commented Nov 30, 2014

Add some more advanced completions for the emerge command.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Jan 19, 2015

Member

Merged with rebase as 789a542..f920be5.

I must admit those completions look very slow; lots of forking with long pipelines. I don't use Gentoo so I can't comment but they might be a good target for optimisation.

Member

zanchey commented Jan 19, 2015

Merged with rebase as 789a542..f920be5.

I must admit those completions look very slow; lots of forking with long pipelines. I don't use Gentoo so I can't comment but they might be a good target for optimisation.

@zanchey zanchey closed this Jan 19, 2015

@zanchey zanchey added this to the next-minor milestone Jan 19, 2015

@zanchey zanchey self-assigned this Jan 19, 2015

@JelteF JelteF deleted the JelteF:emerge-completions branch Jan 19, 2015

@JelteF

This comment has been minimized.

Show comment
Hide comment
@JelteF

JelteF Jan 19, 2015

Contributor

They weren't much slower than before, but they are quite slow in comparison to others. You can really feel it thinking when pressing tab. I think it takes close to a second. What takes longest I think is gathering all possible packages, but I'm not sure. I might look into optimizing it a bit in the future, I don't really care for it that much though. It's not something I auto complete that often, so I don't mind the one second delay that much.

Contributor

JelteF commented Jan 19, 2015

They weren't much slower than before, but they are quite slow in comparison to others. You can really feel it thinking when pressing tab. I think it takes close to a second. What takes longest I think is gathering all possible packages, but I'm not sure. I might look into optimizing it a bit in the future, I don't really care for it that much though. It's not something I auto complete that often, so I don't mind the one second delay that much.

@zanchey

This comment has been minimized.

Show comment
Hide comment
@zanchey

zanchey Jan 19, 2015

Member

The other option would be copying the behaviour of __fish_print_packages and using a cache.

Member

zanchey commented Jan 19, 2015

The other option would be copying the behaviour of __fish_print_packages and using a cache.

@JelteF

This comment has been minimized.

Show comment
Hide comment
@JelteF

JelteF Jan 19, 2015

Contributor

Hmm, there's an application that sort of does that already to make searching through the packages faster. It might be possible to use it for this. It is called eix and as far as I know most Gentoo guys have it installed. It might be good to use that when available and use the current as a fallback.

Contributor

JelteF commented Jan 19, 2015

Hmm, there's an application that sort of does that already to make searching through the packages faster. It might be possible to use it for this. It is called eix and as far as I know most Gentoo guys have it installed. It might be good to use that when available and use the current as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment