Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCS-agnostic prompts #2592

Closed
wants to merge 6 commits into from
Closed

VCS-agnostic prompts #2592

wants to merge 6 commits into from

Conversation

faho
Copy link
Member

@faho faho commented Dec 9, 2015

This ports the prompts that actually used __fish_git_prompt to a new function __fish_vcs_prompt that just calls all shipped vcs prompts.

This should close #2431.

The remaining questions are:

  • Do we mark which vcs it is?
  • Do we rename the prompts ("Informative Git" to "Informative VCS", even though it doesn't enable an informative mode for other prompts, "Classic + Git" to "Classic + VCS", even though it has universal variables with a "__fish_classic_git" prefix)?

CC @Siecje, @derekstavis.

@faho
Copy link
Member Author

faho commented Dec 9, 2015

This also touches #2582, which should also be added to __fish_vcs_prompt once it's merged.

@faho
Add __fish_vcs_prompt helper function
2d4e863 
This is supposed to be used by prompts so they'll get all known vcsen
integrated.

For now, there's no distinction between the different vcsen.
@faho
Switch classic + git prompt to all vcsen
f3d8158 
Keep the name as that's used in variables.
@faho
Make lonetwin prompt use __fish_vcs_prompt
b3a632d
@faho
Make informative_git prompt use vcs_prompt
2f8a0f0
@faho
Add svn to __fish_vcs_prompt
d20f55a
@faho
Update makepkg completion
d0298da 
A few options were missing and --asroot has been removed
@faho
Copy link
Member Author

faho commented Dec 16, 2015

Merged as baa6971..482cfca.

@faho faho closed this Dec 16, 2015
@faho faho deleted the vcs-prompt branch December 16, 2015 18:06
@faho faho mentioned this pull request Dec 16, 2015
Closed
@zanchey zanchey added this to the next-2.x milestone Dec 17, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
fish 2.3.0
Development

Successfully merging this pull request may close these issues.

Add Mercurial to Git Prompt
2 participants
@faho @zanchey