New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS-agnostic prompts #2592

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@faho
Member

faho commented Dec 9, 2015

This ports the prompts that actually used __fish_git_prompt to a new function __fish_vcs_prompt that just calls all shipped vcs prompts.

This should close #2431.

The remaining questions are:

  • Do we mark which vcs it is?
  • Do we rename the prompts ("Informative Git" to "Informative VCS", even though it doesn't enable an informative mode for other prompts, "Classic + Git" to "Classic + VCS", even though it has universal variables with a "__fish_classic_git" prefix)?

CC @Siecje, @derekstavis.

@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Dec 9, 2015

Member

This also touches #2582, which should also be added to __fish_vcs_prompt once it's merged.

Member

faho commented Dec 9, 2015

This also touches #2582, which should also be added to __fish_vcs_prompt once it's merged.

faho added some commits Dec 9, 2015

Add __fish_vcs_prompt helper function
This is supposed to be used by prompts so they'll get all known vcsen
integrated.

For now, there's no distinction between the different vcsen.
Switch classic + git prompt to all vcsen
Keep the name as that's used in variables.
Update makepkg completion
A few options were missing and --asroot has been removed
@faho

This comment has been minimized.

Show comment
Hide comment
@faho

faho Dec 16, 2015

Member

Merged as baa6971..482cfca.

Member

faho commented Dec 16, 2015

Merged as baa6971..482cfca.

@faho faho closed this Dec 16, 2015

@faho faho deleted the faho:vcs-prompt branch Dec 16, 2015

@faho faho referenced this pull request Dec 16, 2015

Closed

Add Mercurial to Git Prompt #2431

@zanchey zanchey added this to the next-2.x milestone Dec 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment