-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill etc/config.fish #2799
Kill etc/config.fish #2799
Conversation
This means one less file in /etc for packagers to deal with and preserves the semantics
lgtm |
Perhaps we should leave a skeleton file in
|
A bunch of the actual empty-/etc stuff is being done in the OSTree project, On Mon, Mar 7, 2016 at 4:13 AM, Fabian Homborg notifications@github.com
|
This contains a bit of information on how fish's configuration works for the admin, but fish still won't _require_ anything from /etc as the file can be safely removed.
r+ - go ahead and merge. As a packager I'm not fussed by no-op files, but as a systems admin I'd like to have a template or example available. |
Merged as 6288f89. Thanks! |
(Sorry, I know this is a bit late)
Like @amluto asked for in #2498, remove etc/config.fish by appending the code to share/config.fish.
This improves life for packagers as there's one less file in etc (thought of as user/admin territory in recent years). Also there's one less file for us to worry about.
It might be nice to nix these two remaining things entirely but I'm not too sure about that.
While I was at it, I've also stringified it, which is why I'd like a quick check from someone else.