Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix patch completion #4560

Merged
merged 1 commit into from
Nov 29, 2017
Merged

fix patch completion #4560

merged 1 commit into from
Nov 29, 2017

Conversation

wwwjfy
Copy link
Contributor

@wwwjfy wwwjfy commented Nov 29, 2017

No description provided.

patch -i should be followed by a filename, and patch -d should be
followed by a directory
@ridiculousfish
Copy link
Member

I'm happy to merge this, but first can you please explain what this fixes? Thanks!

@wwwjfy
Copy link
Contributor Author

wwwjfy commented Nov 29, 2017

It's related to #112, the discussion began at #112 (comment)

The -i parameter of patch should be followed by a filename, with -f (--no-files) in the original file, it could not complete as the users expect.

The other changes are similar, and -d should be followed by a directory

@faho faho added bug Something that's not working as intended completions enhancement labels Nov 29, 2017
@faho faho added this to the fish-3.0 milestone Nov 29, 2017
@faho faho merged commit 7d055a1 into fish-shell:master Nov 29, 2017
@faho
Copy link
Member

faho commented Nov 29, 2017

Merged, thanks for the quick reaction!

@wwwjfy wwwjfy deleted the patch-completion branch November 29, 2017 13:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended completions enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants