Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gentoo completions #4911

Merged
merged 6 commits into from Apr 25, 2018
Merged

Gentoo completions #4911

merged 6 commits into from Apr 25, 2018

Conversation

@drwilly
Copy link
Contributor

@drwilly drwilly commented Apr 16, 2018

Improvements for gentoo/portage related completions

drwilly added 5 commits Apr 15, 2018
- fix capitalization
- shorten descriptions
- implement subcommand shortcuts
- add arg completion for 'limit' and 'depth' switches
- improve arg completion for list subcommand in case of -p switch
@@ -0,0 +1,43 @@
function __fish_seen_ebuild_arg -d "Test if an ebuild-argument has been given in the current commandline"
set -l cmd (commandline -poc)
Copy link
Member

@faho faho Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function can be replaced with

commandline -opc | string match -q '*.ebuild'

Loading

Copy link
Contributor Author

@drwilly drwilly Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

Loading

greatly simplify __fish_seen_ebuild_arg
@faho faho merged commit 0b0e65a into fish-shell:master Apr 25, 2018
1 check passed
Loading
@faho
Copy link
Member

@faho faho commented Apr 25, 2018

Merged, thanks!

Loading

@faho faho added this to the fish-3.0 milestone Apr 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants