Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting of redirection to - (close file descriptor) #6109

Merged
merged 1 commit into from Sep 14, 2019
Merged

Fix highlighting of redirection to - (close file descriptor) #6109

merged 1 commit into from Sep 14, 2019

Conversation

krobelus
Copy link
Member

Fixes #6092

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

mqudsi
mqudsi approved these changes Sep 14, 2019
View reviewed changes
Copy link
Contributor

@mqudsi mqudsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this, LGTM!

@mqudsi mqudsi merged commit 0ecfc25 into fish-shell:master Sep 14, 2019
@zanchey zanchey added this to the fish 3.1.0 milestone Sep 16, 2019
@krobelus krobelus deleted the redirection-highlight-closed-fd branch September 21, 2019 21:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mqudsi mqudsi mqudsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
fish 3.1.0
Development

Successfully merging this pull request may close these issues.

Closed input/output fd redirection highlighting
3 participants
@krobelus @mqudsi @zanchey