Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed input/output fd redirection highlighting #6092

Closed
mqudsi opened this issue Sep 7, 2019 · 0 comments · Fixed by #6109
Closed

Closed input/output fd redirection highlighting #6092

mqudsi opened this issue Sep 7, 2019 · 0 comments · Fixed by #6109
Labels
bug Something that's not working as intended
Milestone
fish 3.1.0

Comments

@mqudsi
Copy link
Contributor

mqudsi commented Sep 7, 2019

When redirecting input/output to a closed fd, the - is not highlighted the same way it would have been for a numbered fd, in fact, it's colored as if it were a regular path.

Compare

image

to

image
@zanchey zanchey added the bug Something that's not working as intended label Sep 8, 2019
@zanchey zanchey added this to the fish-future milestone Sep 8, 2019
krobelus added a commit to krobelus/fish-shell that referenced this issue Sep 12, 2019
@krobelus
Fix highlighting of redirection to - (close file descriptor)
f5e96f8 
Fixes fish-shell#6092
@krobelus krobelus mentioned this issue Sep 12, 2019
Merged
3 tasks
mqudsi pushed a commit that referenced this issue Sep 14, 2019
@krobelus @mqudsi
Fix highlighting of redirection to - (close file descriptor)
0ecfc25 
Fixes #6092
@zanchey zanchey modified the milestones: fish-future, fish 3.1.0 Sep 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something that's not working as intended
Projects
None yet
Milestone
fish 3.1.0
Development

Successfully merging a pull request may close this issue.

Fix highlighting of redirection to - (close file descriptor) krobelus/fish-shell
2 participants
@zanchey @mqudsi