Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper package imports #87

Closed
5 tasks done
droglenc opened this issue Feb 13, 2022 · 1 comment
Closed
5 tasks done

Improper package imports #87

droglenc opened this issue Feb 13, 2022 · 1 comment
Assignees
Labels

Comments

@droglenc
Copy link
Contributor

droglenc commented Feb 13, 2022

A CRAN note (for v0.9.2) indicates that we ask that functions from dplyr and sciplot be imported in FSA. However, with the removal of some deprecated functions from v0.9.1, there are no more imports from these packages.

  • dplyr is still used in some examples so it should be removed from "imports" and put in "suggests" in the DESCRIPTION file.
  • sciplot is no longer needed and the following three changes should be made.
    • Remove library(sciplot) from InstallTester.R
    • Change \code{\link[sciplot]{se}} to \code{se} on line 773 in FSAUtils.R
    • Remove sciplot from "imports" in the DESCRIPTION file.

Also note that there was a testing error related to ksTest() on some flavors of machines (brought to our attention by Prof. Ripley on 15-Feb-22).

  • Modified the test to use the names returned by ks.test() rather than hard-coding the names. [This was tested on the M1 builder on 15-Feb-22 and it appears to have passed.]
@droglenc droglenc self-assigned this Feb 15, 2022
@droglenc droglenc added the bug label Feb 15, 2022
@droglenc
Copy link
Contributor Author

Fixed in v0.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant