Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_49 test case seems to be incorrect #72

Closed
pacificlion opened this issue Apr 10, 2020 · 1 comment
Closed

_49 test case seems to be incorrect #72

pacificlion opened this issue Apr 10, 2020 · 1 comment

Comments

@pacificlion
Copy link

pacificlion commented Apr 10, 2020

Hi,
the test case written for _49 does not check if anagrams are grouped together correctly. It only cares if all the elements given in input are a part of the actual ArrayList. Eg: if I have incorrect grouping as follows for expected , the test case will still pass:

{
  {"eat", "ate", "tea"},
  {"tan"},
  {"nat","bat"}
}

assertEquals(expected.containsAll(actual), actual.containsAll(expected));

Please let me know if I missed anything

Regards,
Prashant

@fishercoder1534
Copy link
Owner

Good call, I've just fixed this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants