Put mines back. #117
Merged
Put mines back. #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindaro
force-pushed
the
feature/mines
branch
from
42e2a22
to
6ee8230
Compare
|
I chose to qualitatively deviate from the original behaviour in one instance: in this draft mines are thrown with velocity 0. I think this is more cool because it communicates that they are attached to the floor and differentiates them from grenades. Please comment on this! |
|
Let us wait for #113 to get merged. I set this to draft to avoid accidental merge but it is ready for review! |
|
Added the new explosive system so it doesn’t compile now, but that should be easily fixed! |
|
Yep, I shall re-base this. |
kindaro
force-pushed
the
feature/mines
branch
2 times, most recently
from
2ccd0af
to
81cabce
Compare
Resolve fishfolk#99. * Checked out from 3ba21b6 — the last commit where this weapon existed. * Uses work in progress from fishfolk#113 for explosive projectiles.
|
Ready to be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #99.
Checked out from 3ba21b6 — the last
commit where this weapon existed.
Uses work in progress from Standardised explosives #113 for explosive projectiles. Since that work is behind
mainby a few commits, I simply copied the files I needed. This patch will become half its current size once Standardised explosives #113 is merged.