Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put mines back. #99

Closed
1 of 4 tasks
kindaro opened this issue Sep 14, 2021 · 6 comments · Fixed by #117
Closed
1 of 4 tasks

Put mines back. #99

kindaro opened this issue Sep 14, 2021 · 6 comments · Fixed by #117
Labels
topic:item Interactive items, e.g. equipment

Comments

@kindaro
Copy link
Collaborator

kindaro commented Sep 14, 2021 •
edited

Mines were added in #8. They were later removed, but I am going to put them back, as fatal and insidious as ever.

  • Adjustable trigger delay.
  • Trigger radius independent of explosion radius.
    • Trigger radius larger than explosion radius?
  • Explosions trigger mines in their radius?
@grufkork
Copy link
Collaborator

I am currently working on reimplementing the cannon and cannonball, as well as the actual hit detection to the explosion function. Unless you are really feeling like adding back the circle and related, I am currently working on it so you could just for the moment use the explosion function in utils.rs? It's only visual at the moment.

@kindaro
Copy link
Collaborator Author

kindaro commented Sep 15, 2021

Sure, thanks for letting me know. I see you have #92 in works.

@grufkork
Copy link
Collaborator

Alright, I got the explosions working again, so just make sure the particles go in the right place! My new code will have a function for returning all players intersecting a circle which could be useful, but it might just be better and more performant to do a distance check instead. By the way, are you in the discord? I couldn't find you there.

@erlend-sh erlend-sh mentioned this issue Sep 15, 2021
Closed
11 tasks
@kindaro
Copy link
Collaborator Author

kindaro commented Sep 16, 2021

Yes — I am not an especially real time person though.

@kindaro
Copy link
Collaborator Author

kindaro commented Sep 23, 2021

Waiting for #113.

@erlend-sh erlend-sh added the topic:item Interactive items, e.g. equipment label Sep 25, 2021
@kindaro kindaro mentioned this issue Sep 25, 2021
Closed
kindaro added a commit to kindaro/FishFight that referenced this issue Sep 25, 2021
@kindaro
Put mines back.
42e2a22 
Resolve fishfolk#99.

* Checked out from 3ba21b6 — the last
  commit where this weapon existed.

* Uses work in progress from fishfolk#113 for explosive projectiles.
@kindaro kindaro mentioned this issue Sep 25, 2021
Merged
kindaro added a commit to kindaro/FishFight that referenced this issue Sep 25, 2021
@kindaro
Put mines back.
6ee8230 
Resolve fishfolk#99.

* Checked out from 3ba21b6 — the last
  commit where this weapon existed.

* Uses work in progress from fishfolk#113 for explosive projectiles.
@kindaro
Copy link
Collaborator Author

kindaro commented Sep 25, 2021 •
edited

Trigger delay needs to be put into #113 as a field in DetonationParameters with default 0. We can talk about it once #113 is merged.

kindaro added a commit to kindaro/FishFight that referenced this issue Sep 29, 2021
@kindaro
Put mines back.
2ccd0af 
Resolve fishfolk#99.

* Checked out from 3ba21b6 — the last
  commit where this weapon existed.

* Uses work in progress from fishfolk#113 for explosive projectiles.
kindaro added a commit to kindaro/FishFight that referenced this issue Sep 29, 2021
@kindaro
Put mines back.
81cabce 
Resolve fishfolk#99.

* Checked out from 3ba21b6 — the last
  commit where this weapon existed.

* Uses work in progress from fishfolk#113 for explosive projectiles.
erlend-sh pushed a commit that referenced this issue Sep 29, 2021
@kindaro
Put mines back. (#117)
ff14a11 
Resolve #99.

* Checked out from 3ba21b6 — the last
  commit where this weapon existed.

* Uses work in progress from #113 for explosive projectiles.
@kindaro kindaro mentioned this issue Sep 30, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:item Interactive items, e.g. equipment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put mines back. kindaro/FishFight
3 participants
@erlend-sh @kindaro @grufkork