Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passive Effect Sprites #414

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Passive Effect Sprites #414

merged 2 commits into from
Apr 12, 2022

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Apr 8, 2022 •
edited
Loading

Depends on #413.

Adds an easy way to add sprites to passive effects.

@zicklag
Make Eaiser to Create Animated Sprites From Meta
e5c5db3 
`impl From<AnimatedSpriteMetadata> for Animated Sprite` and clean
up some of the code that could benefit from it.
@zicklag
Copy link
Member Author

zicklag commented Apr 8, 2022 •
edited
Loading

Clippy is complaining because adding a sprite field to the passive effect makes it's variant much larger than the other in AnyEffectParams. It suggested boxing PassiveEffectMetadata, is that something we want to do?

@orhun
Copy link
Member

orhun commented Apr 10, 2022

Clippy is complaining because adding a sprite field to the passive effect makes it's variant much larger than the other in AnyEffectParams. It suggested boxing PassiveEffectMetadata, is that something we want to do?

Sure, I think it is fine to Box it.

@olefasting olefasting merged commit 4586de8 into fishfolk:main Apr 12, 2022
@zicklag zicklag deleted the passive-effect-sprites branch April 12, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zicklag @orhun @olefasting