Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Fish When They Fall Out of Bounds #429

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented May 23, 2022

This fixes the issue where, on levels that you can fall off of, the fish falls off and continues falling forever without dying.

Also, it addresses the issue where the camera try to adjust to follow the falling fish outside of the play area, causing issues with parallax backgrounds.

Before:
Peek 2022-05-23 14-20

After:
Peek 2022-05-23 14-19

@zicklag
Copy link
Member Author

zicklag commented May 23, 2022

Should I be basing any of my pull requests off of main_borked for now to avoid having to rebase it later?

@olefasting olefasting merged commit de1fb6d into fishfolk:main Jun 2, 2022
@olefasting
Copy link
Member

Should I be basing any of my pull requests off of main_borked for now to avoid having to rebase it later?

No, I am in the process of remergin and it will be easier for me just to add in your code

@zicklag zicklag deleted the kill-out-of-bounds branch June 2, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants