Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sliding collisions #911

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

nelson137
Copy link
Contributor

Closes #910

This was more simple than I expected. When a sliding player collides with something and stops moving, the transform adjustment to stand up didn't take into account the direction the player is facing.

fixed-collisions.mp4

@nelson137
Copy link
Contributor Author

This advisory check task will pass once #909 is merged and I rebase

@zicklag
Copy link
Member

zicklag commented Jan 24, 2024

Oh, sweet! That's so nice to have fixed. It's one of those small wrinkles that has bugged me since I ported the original physics. :)

@zicklag zicklag added this pull request to the merge queue Jan 25, 2024
Merged via the queue into fishfolk:main with commit 3e99ea2 Jan 25, 2024
7 of 8 checks passed
@nelson137 nelson137 deleted the fix/sliding-collision branch January 25, 2024 18:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect collision when player slides into the right side of a solid
2 participants