Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: cannot read gamma spectra from new fispact output #19

Closed
dvp2015 opened this issue Jun 9, 2019 · 1 comment
Closed

Bug: cannot read gamma spectra from new fispact output #19

dvp2015 opened this issue Jun 9, 2019 · 1 comment

Comments

@dvp2015
Copy link
Contributor

dvp2015 commented Jun 9, 2019

Found bug on gamma spectra reading from fispact 4 output.
The bug is reproduced in test, which was added at dvp2015 fork: https://github.com/pypact, branch gamma_spectra_read_bug
See tests/output/test_gamma_spectra_reading.py

The reason is that pypact reading is based on certain number of spaces in output, but the spaces number was changed in our fispact version.

I'm taking on the fix.

I would suggest also to introduce to pypact dependency on numpy to avoid reinventing the wheel. Anyway numpy is just necessary for further analysis modules using pypact. The implementation can also rely on numpy and, probably, xarray. But this is a subject of further issues, not this one. Let's fix the bug first.

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants