NodeJS Function Run Container #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First cut of a function run container for NodeJS. So far, just the simplest stuff: loads a user function and routes requests to it. The user function is assumed to be in a file at a provided location. The fission runtime is expected to place the file there securely (exactly how we'll do that is TBD). Doesn't handle path template params, query strings, etc. Will also need to be extended later with some sort of hook for graceful shutdown.
|
@bcle please take a look |
| @@ -0,0 +1,77 @@ | |||
| 'use strict'; | |||
|
|
|||
| var fs = require('fs'); | |||
There was a problem hiding this comment.
Most of these can be "const"s instead of vars. And if you really need var, chances are it can be a "let". Scan through the code and seek other opportunities to change this.
And log errors to stderr instead of stdout.
We should have real tests with mocha/chai etc. Until then, use this little bash script.
And we aren't using the 'start' command either.
jgavinray
added a commit
that referenced
this pull request
Dec 24, 2016
# This is the 1st commit message: Changed package names to match the new organization # This is the commit message #2: Forgot Cache
smruthi2187
added a commit
to smruthi2187/fission
that referenced
this pull request
Jan 17, 2018
…omponent and Storage Layer component.
smruthi2187
added a commit
that referenced
this pull request
Jan 30, 2018
…t and Storage Layer component.
life1347
pushed a commit
that referenced
this pull request
Feb 1, 2018
All functions have a pkg reference. This can be a package with either source and a deploy archives, or, a deploy archive. Everytime a function is updated, a new package is created. With archive pruner, the archives that are pointed to by old pkg reference can be deleted from the storage. * High level spec for package pruning. * Skeleton for archive pruning * Adding meat 1 to skeleton. * Adding meat #2. Separated storage service into a httpHandler component and Storage Layer component. * Adding meat #3. getOrphanedArchives in pruner and getItems on stowClient. * Restructured archivePruner methods. * Commiting the day's work. Ready for testing #1. * Fixing compile errors. * Test ready. added a few logs for debugging. * Adding a filter for getItems in stowClient. * After testing. * Added a test for archivePruner. * Adding helm value pruneInterval for testing. * Modified test. * Final test. * Fixing interval from seconds to minutes. * Small change. * Changing debugs to info. * Removing the WIP design * Ran gofmt on all these files. * Fixing prune_interval as string in ENV var. * Addressing all comments, but one. * changing getFile method in stowClient to stream it into a response. * All comments incorporated. * Introducing a new flag for running archivePruner. 1. This flag is disabled for archivePruner to run in unit test. 2. This flag is enabled for archivePruner to run in production. 3. Also disabling test_archive_pruner.sh in this PR. Follow up with next PR to enable it. * Addressing review comments. * Changing the command to generate a file dynamically. * Enabling arching_pruner_test * giving execute permissions to test_archive_pruner.sh * Making changes of positional parameters after recent commit. Change test case permission and removing kubectlPortForward. * Adding debug to see why test_utils.sh passed junk pruneInterval. * shell needs special handling for positional parameters from 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut of a function run container for NodeJS. So far, just the
simplest stuff: loads a user function and routes requests to it. The
user function is assumed to be in a file at a provided location. The
fission runtime is expected to place the file there securely (exactly
how we'll do that is TBD).
Doesn't handle path template params, query strings, etc. Will also
need to be extended later with some sort of hook for graceful
shutdown.