Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed spec deletion order according to dependency #2344

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

blackfly19
Copy link
Contributor

@blackfly19 blackfly19 commented Feb 7, 2022

Description

Changed spec deletion order according to dependency.

Which issue(s) this PR fixes:

Testing

Tested using this example. https://github.com/fission/examples/tree/master/spec-example/hello-spec-exmaple

Sample Output:

  • fission spec destroy
Deleted Function default/hello
Deleted Package default/hello-pkg
Deleted Environment default/python-27

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #2344 (0413781) into master (3ac1881) will not change coverage.
The diff coverage is n/a.

❗ Current head 0413781 differs from pull request most recent head 8aa85ba. Consider uploading reports for the commit 8aa85ba to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2344   +/-   ##
=======================================
  Coverage   18.79%   18.79%           
=======================================
  Files          56       56           
  Lines        6295     6295           
=======================================
  Hits         1183     1183           
  Misses       5028     5028           
  Partials       84       84           
Flag Coverage Δ
unittests 18.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac1881...8aa85ba. Read the comment docs.

@sanketsudake sanketsudake merged commit e1fb5a7 into master Feb 8, 2022
@sanketsudake sanketsudake deleted the specDeleteOrder branch February 8, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants