Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Fission resource for specific namespace in newdeploy reaper #2590

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

shubham-bansal96
Copy link
Contributor

Description

Which issue(s) this PR fixes:

Fixes #

Testing

Checklist:

  • I ran tests as well as code linting locally to verify my changes.
  • I have done manual verification of my changes, changes working as expected.
  • I have added new tests to cover my changes.
  • My changes follow contributing guidelines of Fission.
  • I have signed all of my commits.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #2590 (157d0e3) into main (47cbbef) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
+ Coverage   19.76%   19.78%   +0.01%     
==========================================
  Files          62       62              
  Lines        7001     7001              
==========================================
+ Hits         1384     1385       +1     
+ Misses       5511     5510       -1     
  Partials      106      106              
Flag Coverage Δ
unittests 19.78% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/httpserver/server.go 61.11% <0.00%> (+5.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanketsudake sanketsudake merged commit 9ff9a6e into main Oct 31, 2022
@sanketsudake sanketsudake deleted the newdeploy-namespace-specific-resources branch November 2, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants