Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router liveness #701

Merged
merged 4 commits into from
Jul 3, 2018
Merged

Router liveness #701

merged 4 commits into from
Jul 3, 2018

Conversation

smruthi2187
Copy link
Contributor

@smruthi2187 smruthi2187 commented May 23, 2018

This solves the bug that causes the issue #641


This change is Reviewable

Copy link
Member

@soamvasani soamvasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@@ -153,6 +153,11 @@ func (roundTripper RetryingRoundTripper) RoundTrip(req *http.Request) (resp *htt

overhead := time.Since(startTime)

// if transport.RoundTrip succeeds and it was a cached entry, then tapService
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment needs update?

@vishal-biyani vishal-biyani added this to the 0.8.0 milestone May 28, 2018
@soamvasani soamvasani modified the milestones: 0.8.0, 0.9.0 May 30, 2018
@smruthi2187 smruthi2187 self-assigned this Jun 14, 2018
@smruthi2187 smruthi2187 merged commit 9daf97a into master Jul 3, 2018
@life1347 life1347 deleted the routerLiveness branch July 4, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants