Fix CLI failed to set up port-forwarding when multiple controller pods exist in the same namespace #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soamvasani
reviewed
Jun 1, 2018
fission/portforward.go
Outdated
| nsList = append(nsList, p.Namespace) | ||
| } | ||
| } | ||
| if len(nsList) > 1 { |
There was a problem hiding this comment.
Don't you have to handle the case where there are more pods but only one namespace? For some reason, just in case it happens? In that case you have to talk to any pod that's in a healthy state...
There was a problem hiding this comment.
Thank for pointing that out! Just push a new commit to fix the problem.
life1347
force-pushed
the
handle-multiple-controller-pod-in-one-ns
branch
2 times, most recently
from
f821c33
to
b163931
Compare
life1347
force-pushed
the
handle-multiple-controller-pod-in-one-ns
branch
from
b163931
to
c770f2f
Compare
|
LGTM |
life1347
added a commit
that referenced
this pull request
Aug 16, 2018
life1347
added a commit
that referenced
this pull request
Aug 17, 2018
garyyeap
pushed a commit
to garyyeap/fission
that referenced
this pull request
Sep 14, 2018
…s exist in the same namespace (fission#712) * Fix CLI failed to set up port-forwarding when multiple controller pods exist in the same namespace * Check pod healthy state before establishing the connection
garyyeap
pushed a commit
to garyyeap/fission
that referenced
this pull request
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
runPortForwardonly checks amount of controllers not the namespaceSolution
Use map to filter same namespace and check length of namespace list.
This change is