Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI failed to set up port-forwarding when multiple controller pods exist in the same namespace #712

Merged
merged 3 commits into from Aug 2, 2018
Merged

Fix CLI failed to set up port-forwarding when multiple controller pods exist in the same namespace #712

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e361f9
Fix CLI failed to set up port-forwarding when multiple controller pod…
life1347 May 30, 2018
c770f2f
Check pod healthy state before establishing connection
life1347 Jun 7, 2018
92e2a60
Merge branch 'master' into handle-multiple-controller-pod-in-one-ns
vishal-biyani Aug 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 29 additions & 7 deletions fission/portforward/portforward.go
View file
Open in desktop
Expand Up @@ -25,12 +25,14 @@ import (
"strings"
"time"

"k8s.io/api/core/v1"
meta_v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/tools/clientcmd"
"k8s.io/client-go/tools/portforward"
"k8s.io/client-go/transport/spdy"

"github.com/fission/fission"
"github.com/fission/fission/fission/log"
)

Expand Down Expand Up @@ -126,19 +128,39 @@ func runPortForward(kubeConfig string, labelSelector string, localPort string, n
log.Fatal("Error getting controller pod for port-forwarding")
}

nsList := make([]string, 0)
namespaces := make(map[string][]*v1.Pod)

// make a useful error message if there is more than one install
if len(podList.Items) > 1 {
namespaces := make([]string, 0)
for _, p := range podList.Items {
namespaces = append(namespaces, p.Namespace)
if _, ok := namespaces[p.Namespace]; !ok {
namespaces[p.Namespace] = []*v1.Pod{}
nsList = append(nsList, p.Namespace)
}
namespaces[p.Namespace] = append(namespaces[p.Namespace], &p)
}
if len(nsList) > 1 {
log.Fatal(fmt.Sprintf("Found %v fission installs, set FISSION_NAMESPACE to one of: %v",
len(namespaces), strings.Join(nsList, " ")))
}
log.Fatal(fmt.Sprintf("Found %v fission installs, set FISSION_NAMESPACE to one of: %v",
len(podList.Items), strings.Join(namespaces, " ")))
}

// pick the first pod
podName := podList.Items[0].Name
podNameSpace := podList.Items[0].Namespace
pods, ok := namespaces[ns]
if !ok {
log.Fatal(fmt.Sprintf("Error finding fission install within the given namespace %v, please check FISSION_NAMESPACE is set properly", ns))
}

var podName, podNameSpace string

// make sure we establish the connection to a healthy pod
for _, p := range pods {
if fission.IsReadyPod(p) {
podName = p.Name
podNameSpace = p.Namespace
break
}
}

// get the service and the target port
svcs, err := clientset.CoreV1().Services(podNameSpace).
Expand Down