Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Read on Closed body error #963

Merged
merged 5 commits into from
Nov 21, 2018
Merged

Fix Read on Closed body error #963

merged 5 commits into from
Nov 21, 2018

Conversation

smruthi2187
Copy link
Contributor

@smruthi2187 smruthi2187 commented Oct 31, 2018 •
edited by soamvasani
Loading

Issue : #707

This change is Reviewable

soamvasani
soamvasani reviewed Oct 31, 2018
View reviewed changes
Copy link
Member

@soamvasani soamvasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Smruthi, this is great!

router/functionHandler.go Outdated Show resolved Hide resolved
router/functionHandler.go Outdated Show resolved Hide resolved
@life1347 life1347 added this to the 1.0-candidate-1 milestone Nov 5, 2018
soamvasani
soamvasani reviewed Nov 14, 2018
View reviewed changes
Copy link
Member

@soamvasani soamvasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smruthi2187, comments below--

router/functionHandler.go Outdated Show resolved Hide resolved
router/functionHandler.go Show resolved Hide resolved
@life1347
Copy link
Member

LGTM, but I think we should add whole removed comments back since its quite useful. After rebasing master and adding comments, the PR is ready to merge.

soamvasani
soamvasani reviewed Nov 15, 2018
View reviewed changes
Copy link
Member

@soamvasani soamvasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM after restoring the comment.

router/functionHandler.go Outdated Show resolved Hide resolved
@life1347 life1347 merged commit 82af0e5 into master Nov 21, 2018
@life1347 life1347 deleted the fixReadOnClosedBody branch November 21, 2018 06:27
@life1347 life1347 mentioned this pull request Jul 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soamvasani soamvasani soamvasani left review comments

@life1347 life1347 Awaiting requested review from life1347

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@smruthi2187 @life1347 @soamvasani