Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to setTimeout if setImmediate isn't available #7

Closed
fivdi opened this issue Apr 18, 2014 · 3 comments
Closed

Fallback to setTimeout if setImmediate isn't available #7

fivdi opened this issue Apr 18, 2014 · 3 comments

Comments

@fivdi
Copy link
Owner

fivdi commented Apr 18, 2014

Node.js 0.8.x doesn't support setImmediate so fallback to setTimeout if setImmediate isn't available.
@fivdi
Copy link
Owner Author

fivdi commented Apr 18, 2014

Fixed with 3c4162a

@fivdi fivdi closed this as completed Apr 18, 2014
@fivdi fivdi reopened this Apr 20, 2014
@fivdi
Copy link
Owner Author

fivdi commented Apr 20, 2014

Better would be to fallback to nextTick rather than setTimeout if setImmediate is not available. setImmediate is available in Node.js >= v0.10. The semantics of nextTick in Node.js v0.8 are what the lcd module expects. The semantics of nextTick in v0.10 and higher are different and no longer what the lcd module expects.

@fivdi
Copy link
Owner Author

fivdi commented May 1, 2014

Fixed with 387c559

@fivdi fivdi closed this as completed May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fivdi