Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissector - Set config parameter target_field to init=False #372

Closed
niklas-kunz opened this issue Apr 20, 2023 · 1 comment · Fixed by #379
Closed

Dissector - Set config parameter target_field to init=False #372

niklas-kunz opened this issue Apr 20, 2023 · 1 comment · Fixed by #379
Assignees
Labels
bug Something isn't working

Comments

@niklas-kunz
Copy link

For Dissector rules, it is not sensible to set the parameter target_field, since the name of the resulting field(s) is defined by the dissect pattern (mapping). Therefore, init should be set to False (as done e.g. in the SelectiveExtractor).

Please also review if other dissector parameters should be init=False as well.

@niklas-kunz niklas-kunz added the enhancement New feature or request label Apr 20, 2023
@ekneg54 ekneg54 assigned ekneg54 and unassigned ppcad Apr 20, 2023
@ekneg54 ekneg54 added bug Something isn't working and removed enhancement New feature or request labels Apr 20, 2023
@ekneg54
Copy link
Collaborator

ekneg54 commented Apr 20, 2023

thanks for your issue. we will address this as soon as possible by revising the config parameters for all processors and flag them with attrs option init=False if they are not needed

@ekneg54 ekneg54 linked a pull request Apr 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants